Armijn Hemel

Results 142 comments of Armijn Hemel

> > How? No partition has been parsed at this point yet (and this value is needed to be able to find out where partitions start) so how can a...

> If you have a sample and know a range of bytes, it can be brute-forced. And there are tools for it. https://github.com/hn/reolink-camera/blob/master/unpack-novatek-firmware.pl#L101 https://reolink.com/download-center/ Knock yourself out, I am not...

> One field is called `magic` and another one is `signature`... Feels a bit inconsistent. Perhaps. One is for the top level identifier, the other for the individual image entries....

> ```yaml > size: 64 > .... > size-eos: true > ``` > > May it have sense to just replace `size-eos` with the needed size? I don't see a...

> I guess `image_entry` should be nested into `images`, shouldn't it? As far as I know it is nested (clicking through it in the Web IDE now), so I don't...

> Now it is > > ```yaml > types: > images: > ... > image_entry: > ``` > > , but I propose it be > > ```yaml > types:...

The ext2 parser is, in my opinion, only useful to parse the super block. There are many features (such as the sparse superblock ( https://www.nongnu.org/ext2-doc/ext2.html#def-superblock ) that are not properly...

Test files can be found inside the Apple file downloaded from: https://www.dji.com/nl/downloads/softwares/dji-assistant-2-consumer-drones-series

I can confirm that this is indeed a problem. Attached is a minimal test file. [test.zip](https://github.com/kaitai-io/kaitai_struct_formats/files/11523156/test.zip)

Well, found some more files to test with, so I will go back to the drawing board first: https://dev.serpentos.com/pool/b/bash/