linux-rockchip Add firefly-itx-3588j Device tree on Rk 6.1 rkr1

May 15 '24 18:05 SeeleVolleri

oh sorry I forgot adding cooling fan

May 15 '24 19:05 SeeleVolleri

done, squashed

May 16 '24 02:05 SeeleVolleri

done

May 16 '24 02:05 SeeleVolleri

May 16 '24 05:05 SeeleVolleri

I suggest integrating the device tree of this device into a single file. Copying the device tree from the BSP directly for submission is in my opinion a downward spiral in overall readability and quality.

May 16 '24 10:05 chainsx

I'm cleaning up dtsi files now

May 16 '24 19:05 SeeleVolleri

Cleaned up, now building...

May 17 '24 02:05 SeeleVolleri

Makefile change is missing.

May 17 '24 02:05 amazingfate

Thanks for reminding me that!

May 17 '24 02:05 SeeleVolleri

I got a new problem, fixing on that...

[🔨]   Error: arch/arm64/boot/dts/rockchip/rk3588-rk806-single.dtsi:12.26-27 syntax error
[🔨]   FATAL ERROR: Unable to parse input tree
[🔨]   make[3]: *** [scripts/Makefile.lib:422: arch/arm64/boot/dts/rockchip/rk3588-firefly-itx-3588j.dtb] Error 1
[🔨]   make[3]: *** Waiting for unfinished jobs....

May 17 '24 03:05 SeeleVolleri

make ARCH=arm64 dtbs has no errors, I'm going to build armbian tomorrow, my UPS is running out of power. And thanks @chainsx for pointing out build failure because rockchip.h missing pins!

May 20 '24 18:05 SeeleVolleri

I made a very dumb mistake before: Somehow uboot reads rk3588s-roc-pc.dtb and I keep editing rk3588-firefly-itx3588jdts to correct the periphels error. Now it boots flawlessly without any mistake or missing devices, all working! Apologize for verbose pr and commits. Thanks!

May 24 '24 00:05 SeeleVolleri