build icon indicating copy to clipboard operation
build copied to clipboard

WIP: sunxi: bump `edge` to 6.18

Open EvilOlaf opened this issue 1 month ago • 6 comments

Description

An hacked together attempt to bump sunxi family to 6.18 in the major spirit somewhere between I-pretend-to-know-what-I-am-doing and I-have-no-idea-what-I-am-doing.

  • I re-extracted all of megi's patches from their individual branches and sorted them in the same order as megi applied them to their integration branch orange-pi-6.18.
  • Then I did the same with Jernej's refactored sun4i drm patches
    • Removed any sun4i drm patches from megi since they dont play along. Did zero investigation why.

Todo

  • address all remaining disabled patches manually (PLEASE HELP and push your fixes into this branch)
    • patches.armbian/Add-sunxi-addr-driver-Used-to-fix-uwe5622-bluetooth-MAC-address.patch (left untouched until wifi is sorted)
    • patches.armbian/drv-gpu-drm-sun4i-sun8i_mixer.c-add-h3-mixer1.patch (I assume collides with sun4i-drm patchset??)
    • patches.armbian/drv-mfd-axp20x-add-sysfs-interface.patch ???
  • fix uwe wifi. Currently it is disabled since it breaks compilation. Re-enable in drivers_network.sh
  • xradio was fixed by reverting back to the origin of Igor's fork. Either sync fork or adjust wording in the drivers_network.sh

How Has This Been Tested?

  • [ ] an older version of my mess has been tested on OPi1 (sunxi) and OPiZ2 (sunxi64)

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [ ] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

EvilOlaf avatar Dec 09 '25 17:12 EvilOlaf

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

114 files out of 300 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
  • [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 09 '25 17:12 coderabbitai[bot]

@radoslavv @robertojguerra Would you mind addressing enable-TV-Output-on-OrangePi-Zero-LTE.patch ?

EvilOlaf avatar Dec 09 '25 17:12 EvilOlaf

@JohnTheCoolingFan Would you mind checking Fix-ghost-touches-on-tsc2007-tft-screen.patch ? Upstream code has changed and I don't know how to address this.

EvilOlaf avatar Dec 09 '25 17:12 EvilOlaf

@JohnTheCoolingFan Would you mind checking Fix-ghost-touches-on-tsc2007-tft-screen.patch ? Upstream code has changed and I don't know how to address this.

The patch was not fully mainlined, particularly I don't see anything about y direction resistance which is part of Fix-ghost-touches-on-tsc2007-tft-screen.patch. I don't have the tft module to test with, so can't tell if ghost touches still happen now or not.

JohnTheCoolingFan avatar Dec 09 '25 20:12 JohnTheCoolingFan

The patch was not fully mainlined, particularly I don't see anything about y direction resistance which is part of Fix-ghost-touches-on-tsc2007-tft-screen.patch. I don't have the tft module to test with, so can't tell if ghost touches still happen now or not.

https://paste.armbian.com/vuduwugamu

I noticed where u32 rt = 0; is now u64 and I think rest of this hunk also does no longer apply without modification. I don't understand the code's meaning, so I cannot tell if that makes any sense.

EvilOlaf avatar Dec 10 '25 04:12 EvilOlaf

@igorpecovnik regarding uwe5622 wifi: https://paste.armbian.de/debamowini line 9650 ff.

   drivers/net/wireless/uwe5622/unisocwcn/platform/wcn_boot.c: In function 'marlin_registsr_bt_wake':
   drivers/net/wireless/uwe5622/unisocwcn/platform/wcn_boot.c:1387:15: error: implicit declaration of function 'devm_gpio_request'; did you mean 'devm_gpio_request_one'? [-Werror=implicit-function-declaration]
    1387 |         ret = devm_gpio_request(dev, bt_wake_host_gpio,
         |               ^~~~~~~~~~~~~~~~~
         |               devm_gpio_request_one

Asked LLM for solutions. I have no idea if there is any value in these informations. https://www.perplexity.ai/search/since-linux-6-18-the-uwe5622-w-_XeLgd1cQRyYnFsYL6m1fA#0

EvilOlaf avatar Dec 10 '25 04:12 EvilOlaf

@coderabbitai review

EvilOlaf avatar Dec 11 '25 05:12 EvilOlaf

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar Dec 11 '25 05:12 coderabbitai[bot]

I think I sorted most. This needs testing against H3 H5 H6 H616 and H618 devices.

EvilOlaf avatar Dec 11 '25 07:12 EvilOlaf

Tested with Opi Zero2 (H616), seems good. Did only wifi scan to see if it detects anything. No further tests. Fixup scripts are still missing (check linked issue above), but basic functionality is there either way. So this can be addressed later as well.

EvilOlaf avatar Dec 12 '25 06:12 EvilOlaf

@igorpecovnik can we run a build train on this. Perhaps lowering effort level needed for testing by sending out ready to test images to volunteers with allwinner devices?

EvilOlaf avatar Dec 13 '25 09:12 EvilOlaf