build icon indicating copy to clipboard operation
build copied to clipboard

[RFC]: Merge "Work in Progress" label into draft status

Open leggewie opened this issue 3 months ago • 4 comments

What happened?

I suggest we drop the "Work in Progress" label in favor of setting a PR to draft status.

Currently, we have about three ways of indicating that a PR is not quite ready to be merged yet. The above two and the "Changes requested" from a review. Semantically, I don't see the difference between the above and vote to simplify things.

Comments?

How to reproduce?

leggewie avatar Sep 03 '25 20:09 leggewie

Jira ticket: AR-2745

github-actions[bot] avatar Sep 03 '25 20:09 github-actions[bot]

There is fundamental difference - draft is status of PR and means "early POC" "do not look at it yet" "untested" "concept". This information is valuable for users, AI and CI.

While WIP means something that it a lot further then that. It signals that there is active development, something between working and ready to review. tl;dr; I would not change anything here except if this bothers you - add automation on this and leave the database as is.

Lets just close it.

igorpecovnik avatar Sep 04 '25 05:09 igorpecovnik

There is fundamental difference - draft is status of PR and means "early POC" "do not look at it yet" "untested" "concept". This information is valuable for users, AI and CI.

If it really means "do not look at it, yet" then why is it published? Makes absolutely no sense to me.

While WIP means something that it a lot further then that. It signals that there is active development, something between working and ready to review. tl;dr; I would not change anything here except if this bothers you - add automation on this and leave the database as is.

Lets just close it.

How about adding another three or four layers in between to really differentiate the states of "readiness"?

I think Armbian isn't complex and differentiated enough in this aspect, yet. Oh, right, we already have "Changes requested" from reviewers as yet another layer of signaling non-readiness. So awesome. Very important to really get those subtleties right. Problem is, nobody understands the differences between them (maybe there aren't any significant ones?). And I believe I am by far the person who interacted the very most with the tracker here on github over the last few months. And I can't make sense of it, so yes, this paragraph is mostly sarcasm.

What bothers me is not the state of affairs. What bothers me is the underlying base for the choices being made: unnecessary complexities, quirkiness, hackery. And most importantly the fact that they are being defended and that the Armbian administration would rather throw AI tools at it to hack together scripts to deal with the (supposedly unnecessary) complexity than do away with the complexity after all, technically debt-free and actually relieving the Armbian project of slack.

leggewie avatar Sep 04 '25 12:09 leggewie

If I might put in my 2¢, there is another point for consideration: not all users, even "members", can set labels on [their own] PRs. It requires "triage" access. Unless they're supposed to ask one of the bots to do it for them anyway.

tabrisnet avatar Sep 05 '25 04:09 tabrisnet