build icon indicating copy to clipboard operation
build copied to clipboard

ti: Add more firmware, GPU etc packages

Open jsuhaas22 opened this issue 6 months ago • 5 comments

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

TI Debian images support different features, such as IPC, Weston (as OOB screen), GPU acceleration, camera etc. So to have these working by-default in our images, this PR adds certain packages such as:

  • gstreamer (required for camera)
  • chromium
  • GPU and mesa packages
  • k3conf (a diagnostic tool for TI devices)
  • weston ... etc

Additionally, there are 2 more things done here:

  1. Weston service file is added, and placed in /lib/systemd/system/. This is to start weston on boot by-default. Note that weston doesn't launch on first boot when the armbian-firstlogin script runs, but starts launching from subsequent boots.
  2. dkms autoinstall builds and installs the ti-img-rogue--dkms package for the current kernel. If this isn't done here, it will done during first boot, which would make the first boot very slow.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • boot tested AM62x to see weston come up
  • also performed other tests such as wayland-simple-egl and chromium to ensure GPU works

Checklist:

Please delete options that are not relevant.

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] My changes generate no new warnings

jsuhaas22 avatar Jul 11 '25 09:07 jsuhaas22

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

Board configs for SK‑AM62B and SK‑AM64B were updated to declare SOC_ID and GPU/firmware/video-related settings; the K3 family source config (config/sources/families/k3.conf) was extended to initialize and append TI_PACKAGES (including SOC-specific firmware, optional GPU/video packages, and EXTRA_BOARD_PACKAGES). The ti-debpkgs extension gained two functions for pre-customize image service/user setup and post-install DKMS activation. A new emptty package was added with emptty.conf, a PAM config, and weston.ini. The common package list added vim.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • armbian/build#8305 — Modifies TI package handling and the ti-debpkgs extension; strongly overlaps with changes to k3 family config, board configs, and extensions/ti-debpkgs.sh.

Suggested reviewers

  • glneo
  • igorpecovnik
  • leggewie
✨ Finishing touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Jul 11 '25 09:07 coderabbitai[bot]

Starting Weston as a root systemd service was a hack we did for our Yocto SDK distro, it was not correct and we are switching to using a proper weston user and launching with a login-manager (Emptty). For Armbian you should do the same or re-use GDM or similar default manager to launch a weston session.

glneo avatar Jul 14 '25 14:07 glneo

@glneo Understood. I am going with emptty, and got it working using the upstream emptty package. Do we want auto-login into weston like in our Yocto-based SDK, or do we want to show the username/password screen? I am wondering since the first boot takes you through the armbian-firstlogin script setup anyway.

For now, I have gone with auto-login. If you think the alternative is better, I will update the PR.

jsuhaas22 avatar Jul 17 '25 09:07 jsuhaas22

For now, based on internal discussions, I have removed the weston and emptty. It was decided that we should explore ways to introduce these as a separate desktop environment or something similar.

So from now, this PR is for adding extra packages related to vim, firmware, kernel modules etc.

Therefore I have also edited the PR heading.

jsuhaas22 avatar Sep 11 '25 08:09 jsuhaas22

For now, based on internal discussions, I have removed the weston and emptty. It was decided that we should explore ways to introduce these as a separate desktop environment or something similar.

So from now, this PR is for adding extra packages related to vim, firmware, kernel modules etc.

Therefore I have also edited the PR heading.

The first patch still includes make weston the OOB in the commit message, remove that.

glneo avatar Sep 15 '25 17:09 glneo