build icon indicating copy to clipboard operation
build copied to clipboard

extension: add ksrc packaging

Open EvilOlaf opened this issue 7 months ago • 4 comments

Description

A (very poorly made) attempt to address https://github.com/armbian/build/issues/8161

It spits out some sort of kernel source package, but I think {version} is still missing since I couldn't get it to work and probably needs more fixes until production-ready. I probably won't go further here due to lacking expertise in framework and bash foo.

Maybe someone want to pick it up from here.

Also to do: Re-enable BUILD_KSRC switch to enable the extension.

How Has This Been Tested?

  • [x] enable extension
  • [x] see some sort of kernel package being created
  • [ ] ???
  • [ ] Profit!

Checklist:

  • [ ] My code follows the style guidelines of this project - Well...kind of?
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

EvilOlaf avatar May 21 '25 05:05 EvilOlaf

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

A new shell script extension has been added to facilitate packaging the Linux kernel source into a Debian package. The script introduces three primary functions: one to set configuration variables for building the kernel source package, another to add the fakeroot utility to the host dependencies, and a third to handle the actual packaging process. The packaging function checks for the presence of a kernel configuration file, prepares the necessary directory structure, compresses the kernel source, includes documentation and license files, generates Debian package metadata, and builds the package using fakeroot. The script also manages temporary files and provides progress notifications.

✨ Finishing Touches
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar May 21 '25 05:05 coderabbitai[bot]

@coderabbitai review

EvilOlaf avatar May 21 '25 05:05 EvilOlaf

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar May 21 '25 05:05 coderabbitai[bot]

It spits out some sort of kernel source package, but I think {version} is still missing since I couldn't get it to work and probably needs more fixes until production-ready. I probably won't go further here due to lacking expertise in framework and bash foo.

Maybe someone want to pick it up from here.

Also to do: Re-enable BUILD_KSRC switch to enable the extension.

In the previous branch, the package contained only the archive and additional actions were required locally on the system to make it work.

I'll see what I can do about it.

The-going avatar May 23 '25 19:05 The-going

I apologize. I will not take part in this development.

The-going avatar Jun 16 '25 15:06 The-going

Why does this PR have 141 commits? Rebase gone wrong?

leggewie avatar Aug 11 '25 10:08 leggewie

No clue, didnt check this pr since I opened it. Maybe somebody else tried to rebase.

EvilOlaf avatar Aug 11 '25 11:08 EvilOlaf

OK, my guess is that this is due to the fact you started off with a completely new branch. In any case, I rebased this now to the latest main branch and force-pushed. For some reason, github still is hungover on this one.

leggewie avatar Aug 12 '25 07:08 leggewie

Wouldn't be the first PR github messes up. Only way to fix is close an recreate.

EvilOlaf avatar Aug 12 '25 11:08 EvilOlaf