Label on approved is running with wrong permissions

[igorpecovnik]

Description

pull_request_review might not grant required permissions. pull_request_target runs in the context of the base repository (i.e., the one the PR is targeting), giving the correct access to secrets and permissions.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

• [ ] Test A
• [ ] Test B

Checklist:

Please delete options that are not relevant.

• [ ] My code follows the style guidelines of this project
• [ ] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] My changes generate no new warnings
• [ ] Any dependent changes have been merged and published in downstream modules

[coderabbitai[bot]]

Walkthrough

The pull request modifies the workflow configuration in .github/workflows/pr-label-on-approved.yml by changing the event trigger from pull_request_review to pull_request_target. This update enables the workflow to execute in the context of the target repository instead of the source repository. Additionally, the workflow name, job name, and step name have been reformatted with quotation marks. The permissions configuration remains unchanged, and the job's conditions and steps continue to operate as before.

Possibly related PRs

• armbian/build#8079: This PR involves modifications to the workflow, specifically adding a permissions section, which shows a direct code-level relationship with the changes in this pull request.

Suggested reviewers

• rpardini
• hzyitc

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 88ab0c5ad0b86475c9fccf264626528a8f25b1bd and 39b0381c93c9ec92bb2177b0e8c85a886bf2eb9a.

📒 Files selected for processing (1)

• .github/workflows/pr-label-on-approved.yml (2 hunks)

🔇 Additional comments (3)

.github/workflows/pr-label-on-approved.yml (3)

1-2: Workflow Name and Trigger Update

The workflow name is now enclosed in quotes and the event trigger has been changed to pull_request_target. This update ensures that the workflow runs in the context of the target repository, thereby providing the necessary permissions for accessing secrets and performing privileged operations.

---

11-12: Job Condition and Naming Update

The job labelWhenApproved now includes a condition (if: ${{ github.repository_owner == 'armbian' }}) to ensure it executes only for the official repository. Additionally, the job name is formatted with quotes to align with the updated style guidelines, improving consistency and readability.

---

15-16: Step Naming Consistency

The step name is now enclosed in quotes, which is consistent with the workflow and job naming updates. This change has no functional impact but enhances the overall clarity and consistency of the configuration.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[leggewie]

time to getting this merged?

[igorpecovnik]

No, it doesn't work as expected. Need to figure out permissions.

[armbianworker]

Closing in favor of https://github.com/armbian/build/pull/8620