Armbian-install: disable Docker when installing images

[igorpecovnik]

Description

Stop Docker system running Armbina-install to prevent weird results and to speed up. Does it make sense?

How Has This Been Tested?

• [x] Manual test, disabling and installing to eMMC, reboot, works

Checklist:

• [x] My code follows the style guidelines of this project
• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [x] My changes generate no new warnings
• [x] Any dependent changes have been merged and published in downstream modules

[rpardini]

weird results and to speed up. Does it make sense?

Weird results all the time, as armbian-install does an rsync of a running system -- many things can be open and change during the rsync. I think Docker (containerd, really) and its overlay2 filesystem might just be wors-er than most, but the wierdness can happen with many other things.

[rpardini]

The "correct" way of doing this involves creating a temporary initrd and kexec'ing into a new kernel and initrd while leaving the original image unmounted, so that it can be copied without anything open or running on it. It is a huge endeavour though.

[coderabbitai[bot]]

Walkthrough

The script was updated to enhance Docker service management during its execution. The signal trap for INT and TERM signals now restarts the Docker service before the script exits, replacing the previous behavior of immediate exit. Additionally, the create_armbian function was modified to check if the Docker service is active and stop it before proceeding with the installation. No changes were made to the signatures or declarations of exported or public entities.

Suggested labels

ready to merge

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e9708b8c335d0462e5ab06fdc5e852faed06caf8 and 6c77a136583a447209ebc21f9ce569841fe19cc3.

📒 Files selected for processing (1)

• packages/bsp/common/usr/bin/armbian-install (2 hunks)

🔇 Additional comments (2)

packages/bsp/common/usr/bin/armbian-install (2)

23-23: LGTM! Well-implemented signal handling for Docker restart.

The trap modification correctly ensures Docker service is restarted when the script is interrupted via INT or TERM signals. The error suppression is appropriate for cleanup code.

---

129-130: Excellent implementation of Docker service management.

The logic correctly checks if Docker is active before attempting to stop it, preventing unnecessary errors. The conditional execution with && and the clear comment explaining the rationale make this a solid implementation that addresses the rsync interference issues mentioned in the PR objectives.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.