build icon indicating copy to clipboard operation
build copied to clipboard

linux-image: provide wireguard-modules

Open amazingfate opened this issue 11 months ago • 5 comments

Description

I'm trying to generate a debian iso with armbian's kernel, but live-build keep installing linux-image-rt-arm64. I find it as rec dependency of wireguard-tools. And both linux-image-rt-arm64 from debian and linux-image-generic from ubuntu are providing it.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [x] ./compile.sh kernel BOARD=rock-5b BRANCH=vendor DEB_COMPRESS=xz

Checklist:

Please delete options that are not relevant.

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

amazingfate avatar Feb 09 '25 17:02 amazingfate

Provides wireguard-modules solves this problem?

igorpecovnik avatar Feb 09 '25 19:02 igorpecovnik

Provides wireguard-modules solves this problem?

live-build need a apt repo to build. I haven't checked it. I'm finding other way to get rid of the issue so don't be pushed to merge this quickly.

amazingfate avatar Feb 10 '25 01:02 amazingfate

this should eventually be fixed in APA

leggewie avatar Mar 25 '25 11:03 leggewie

this should eventually be fixed in

You mean by introducing virtual kernel package? Otherwise, man packaging should stay "as as" inside build framework. Splitting this is calling for troubles.

igorpecovnik avatar Mar 26 '25 08:03 igorpecovnik

I think that APA is the proper place to document and publish this kind of packaging-related information. There's too much unmaintainable/hard-to-maintain shell code in armbian/build, I would say.

leggewie avatar Mar 26 '25 20:03 leggewie

@igorpecovnik I did not mean to stall this PR, just to mention about the future path we intend to take to raise awareness.

Is there a reason NOT to merge this? I am not sure if the package in question does indeed provide wireguard-modules. If it does not, this should NOT go in. But if it does, it should by all means.

leggewie avatar Jul 21 '25 22:07 leggewie

I think this can be merged as we provide wg modules by default and this is (probably) virtual package that makes modules via DKMS. None of this is needed in Armbian.

igorpecovnik avatar Jul 22 '25 17:07 igorpecovnik

All Armbian kernels should have Wireguard as module by default. This hopefully solves the issue having non-working upstream kernels installed as recommendation when trying to install wireguard-tools.

EvilOlaf avatar Aug 11 '25 11:08 EvilOlaf