build icon indicating copy to clipboard operation
build copied to clipboard

mesa-vpu: don't install mesa-vpu on minimal images

Open igorpecovnik opened this issue 1 year ago • 2 comments

Description

Keeping minimal images as minimal as possible. Addition to: https://github.com/armbian/build/pull/7318

How Has This Been Tested?

CI throws error when trying to add PPA:add-apt-repository: command not found We don't (want) to have software-properties-common package and dependencies on minimal images.

Checklist:

  • [x] My code follows the style guidelines of this project
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules

igorpecovnik avatar Oct 03 '24 15:10 igorpecovnik

Not sure if doing this "silently" is the right approach. What's the reason not to add a hint mesa-vpu is not being installed when minimal is selected? and what to do if users want it anyways for wahtever reason?

EvilOlaf avatar Oct 03 '24 15:10 EvilOlaf

Added warning instead.

igorpecovnik avatar Oct 03 '24 17:10 igorpecovnik

CI breaks without this. Different way can be done later if desired.

igorpecovnik avatar Oct 04 '24 05:10 igorpecovnik