build icon indicating copy to clipboard operation
build copied to clipboard

Deprecate `WIREGUARD`?

Open EvilOlaf opened this issue 1 year ago • 4 comments

Which feature would you like to have?

https://github.com/search?q=repo%3Aarmbian%2Fbuild%20wireguard-tools&type=code It seems like wireguard-tools is already in the list of common packages and WIREGUARD=yes basically installs this package. So besides using it on a minimal image there is no real use for it. So maybe deprecate WIREGUARD entirely now?

Funding

EvilOlaf avatar Sep 19 '24 16:09 EvilOlaf

Jira ticket: AR-2498

github-actions[bot] avatar Sep 19 '24 16:09 github-actions[bot]

So maybe deprecate WIREGUARD entirely now?

Probably best. And deal with this here https://github.com/armbian/configng

igorpecovnik avatar Sep 19 '24 19:09 igorpecovnik

There are a handful of board config files with WIREGUARD=no but I assume this line does not do anything since the wireguard-tools package is part of the common list. Besides those removal is necessary here https://github.com/armbian/build/blob/5e8d48cb7a1202336e2e3cf3b89aef2a0f1b9c09/lib/functions/configuration/main-config.sh#L266 and here https://github.com/armbian/build/blob/5e8d48cb7a1202336e2e3cf3b89aef2a0f1b9c09/lib/functions/rootfs/distro-agnostic.sh#L357

And that should be pretty much it.

EvilOlaf avatar Sep 20 '24 11:09 EvilOlaf

Yeah, it was already a bit not-really-used since armbian-next. Having wireguard nowadays is a question of kernel .config and some userspace nice to haves....

rpardini avatar Sep 20 '24 12:09 rpardini