rockchip-rk3588: rock-5b current, edge: u-boot: bump to mainline 2024.10-rc3
Description
Radxa Rock 5B
- Bump
currentandedgeto mainline 2024.10-rc3 - ensure
ARMV8_CRYPTOis disabled (currently broken) - enable creation of
/chosen/kaslr-seednode (to enable Kernel address space layout randomization)
How Has This Been Tested?
- [x] Built, installed, and succesfully booted trixie current and edge
Checklist:
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] My changes generate no new warnings
2024.10 is aleady realesed, shall we move on with it?
Ping. Is this relevant / ready?
Since 2025.01 is out too maybe go straight there?
Walkthrough
Replaces Kwiboo U-Boot for Rock-5B (edge/current) with upstream mainline U-Boot and moves to a binman-based installation flow. Declares UBOOT_TARGET_MAP to enumerate BL31, ROCKCHIP_TPL and the two prebuilt U-Boot artifacts. Adds write_uboot_platform(source_dir, output_file) (copies u-boot-rockchip.bin via dd) and write_uboot_platform_mtd(source_dir) (flashes u-boot-rockchip-spi.bin to /dev/mtd0 via flashcp). Unsets rockchip64_common postprocess hooks and extends mainline SPI config generation to both edge and current, plus SPI Kconfig tweaks (enable CONFIG_BOARD_RNG_SEED; disable ARMV8 crypto/SHA options).
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
- armbian/build#8428 — Nearly identical board-level changes: switch to mainline U-Boot/binman, add
UBOOT_TARGET_MAP, and newwrite_uboot_platformhooks. - armbian/build#8449 — Related adjustments to the rockchip binman/mainline U-Boot workflow and U-Boot installation plumbing.
Suggested labels
size/large
Suggested reviewers
- rpardini
- amazingfate
- igorpecovnik
- paolosabatino
- pyavitz
- efectn
- ColorfulRhino
- JohnTheCoolingFan
✨ Finishing Touches
🧪 Generate unit tests
- [ ] Create PR with unit tests
- [ ] Post copyable unit tests in a comment
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
-
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR/Issue comments)
Type @coderabbitai help to get the list of available commands.
Other keywords and placeholders
- Add
@coderabbitai ignoreor@coderabbit ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Status, Documentation and Community
- Visit our Status Page to check the current availability of CodeRabbit.
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
I rebased this to main to see if there was any bitrot.
@alexl83 do you still want to go ahead with this PR?
@efectn @ColorfulRhino @HeyMeco Are there some commits in this PR that are a no-brainer to merge. We should get this merged or abandon it (the latter being undesirable).
bitrot test passed with a rebase