build icon indicating copy to clipboard operation
build copied to clipboard

Addressing two problems related to `wireless at firstlogin script`

Open igorpecovnik opened this issue 1 year ago • 5 comments

Description

  • removing network manager dependency. Left over from moving networking into extensions.
  • address errors when wireless networking is still not detected

Jira reference number AR-2390

Documentation summary for feature / change

https://github.com/armbian/documentation/pull/438

How Has This Been Tested?

  • [x] Several images on board without wifi only
  • [x] Tested making wrong wifi password 3x, exits with "Unable to connect to AP"
  • [x] Connecting with correct credentials
  • [x] Choosing to not connect to wireless
  • [x] Tested on NM and systemd networkd

Checklist:

  • [x] My changes generate no new warnings
  • [x] Any dependent changes have been merged and published in downstream modules

igorpecovnik avatar Jun 28 '24 18:06 igorpecovnik

Thanks a lot. I will build noble image and test today.

amazingfate avatar Jun 29 '24 07:06 amazingfate

Here is another issue. I'm testing armsom sige5 with rtl8852bs wifi, which has two wifi interfaces: wlan0 and p2p0. At first login armbian can't detect SSIDs so I just press Enter for null ssid and password. After starting desktop I can't connect wifi because there is file /etc/netplan/30-wifis-dhcp.yaml with following contents:

# Created by Armbian firstlogin script
network:
  wifis:
    p2p0
wlan0:
      dhcp4: yes
      dhcp6: yes
      access-points:
        "":
         password: ""

After deleting this file I can connect wifi.

amazingfate avatar Jun 29 '24 15:06 amazingfate

At first login armbian can't detect SSIDs so I just press Enter for null ssid and password.

Maybe we need to

  1. check if the network can be connected to with the given SSID and password (and only then create the yaml file, otherwise either ask again since user might have a typo, or skip connecting)
  2. check for empty ssid/pw

ColorfulRhino avatar Jun 29 '24 21:06 ColorfulRhino

Cannot tell anything here. Never used wifi in first-login and probably never will.

EvilOlaf avatar Jun 30 '24 03:06 EvilOlaf

Maybe we need to

  • if empty it re-cycle, exits after 3 cycles of selecting network
  • also added several checks
  • tested on dodgy wifi and it works as expected
  • done many many tests.

igorpecovnik avatar Jun 30 '24 09:06 igorpecovnik

Tested with rtl8852bs, I can choose which interface to connect wifi. Nice!

amazingfate avatar Jun 30 '24 15:06 amazingfate