build icon indicating copy to clipboard operation
build copied to clipboard

Add board firefly-itx-3588j

Open SeeleVolleri opened this issue 1 year ago • 6 comments

Description

I have a Firefly-itx-3588j board

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • [x] Build
  • [x] neofetch image

Checklist:

Please delete options that are not relevant.

  • [x] My code follows the style guidelines of this project
  • [x] I have performed a self-review of my own code
  • [x] I have commented my code, particularly in hard-to-understand areas
  • [x] My changes generate lots new warnings
  • [ ] Any dependent changes have been merged and published in downstream modules

SeeleVolleri avatar May 15 '24 17:05 SeeleVolleri

This PR depend on the following PR: https://github.com/armbian/linux-rockchip/pull/188

chainsx avatar May 16 '24 10:05 chainsx

Hi, I wish to add this board's dts file at edge kernel, should I place a single patch at https://github.com/armbian/build/tree/main/patch/kernel/rockchip-rk3588-edge? The patch is a commit from https://github.com/armbian/linux-rockchip/commit/e22606250f245c652c78be53879cb6979300a94d. Are there any naming guideline for patch file? Thanks!

SeeleVolleri avatar May 21 '24 00:05 SeeleVolleri

Just place mainline dts at patch/kernel/rockchip-rk3588-edge/dt/.

amazingfate avatar May 21 '24 01:05 amazingfate

Just place mainline dts at patch/kernel/rockchip-rk3588-edge/dt/.

Does that means the dts must be in mainline kernel git first, then it's able to place in the path you mentioned? Also pinctrl and dts Makefile too?

SeeleVolleri avatar May 21 '24 01:05 SeeleVolleri

Just place mainline dts at patch/kernel/rockchip-rk3588-edge/dt/.

Does that means the dts must be in mainline kernel git first, then it's able to place in the path you mentioned? Also pinctrl and dts Makefile too?

Just dts file would work. That dir is for out-of-tree mainline devicetree. You can see files existing in that dir.

amazingfate avatar May 21 '24 01:05 amazingfate

Thanks!

SeeleVolleri avatar May 21 '24 03:05 SeeleVolleri

@SeeleVolleri If you want to become a board maintainer, adjust data here.

Ref: Board Maintainers Procedures and Guidelines

igorpecovnik avatar Jun 02 '24 08:06 igorpecovnik