build icon indicating copy to clipboard operation
build copied to clipboard

I would like to know difference between BOOTBRANCH and BOOTBRANCH_BOARD

Open buldo opened this issue 2 years ago • 3 comments

Which feature would you like to have?

I think that documentation miss description for BOOTBRANCH and BOOTBRANCH_BOARD variables.
I trying to add support for luckfox core3566. I already created image with yocto and trying to apply my progress to armbian but not understand some variables.

Funding

buldo avatar Jan 15 '24 01:01 buldo

Jira ticket: AR-2026

github-actions[bot] avatar Jan 15 '24 01:01 github-actions[bot]

You're right to be confused. BOOTBRANCH points to the branch/tag/commit to use as git base for u-boot. BOOTBRANCH is usually defined by family code, before we had extensibility/hooks available, so family code was littered with "if board == xyz then this branch", causing board/family mixups. BOOTBRANCH_BOARD was introduced as a pre-hooks way to let the board (not the family) set the branch. Similar was done, I think, for BOOTPATCHDIR?

rpardini avatar Jan 15 '24 16:01 rpardini

@rpardini now I more confused.
Before your answer I used BOOTBRANCH in my board.csc file and build framework understands it without problem.
Moreover more than 10 board definition files use BOOTBRANCH variable.

  1. Have I use BOOTBRANCH_BOARD instead BOOTBRANCH in my board.csc?
  2. If BOOTBRANCH variable prohibited to use in board file maybe it have to be some validations in build steps?

buldo avatar Jan 15 '24 17:01 buldo