armadito-av icon indicating copy to clipboard operation
armadito-av copied to clipboard

CLI on-deman scan does not scan expected path when given path is a relative one

Open vhamon opened this issue 8 years ago • 3 comments

~/workspace/armadito-agent find . -type f | wc -l 595 ~/workspace/armadito-agent sudo /usr/bin/armadito-scan -j -r ./ { "timestamp": 1487857526, "type": "EVENT_ON_DEMAND_COMPLETED", "u": { "ev_on_demand_completed": { "total_malware_count": 0, "total_suspicious_count": 0, "total_scanned_count": 16 } } }

That should be an easy automated test to add by the way.

vhamon avatar Feb 23 '17 13:02 vhamon

In fact, scand consider "." as the directory where daemon is launched, as we can see in the daemon logs, the 16 scanned files are :

[3780.583819] armadito[20855]: starting threaded scan of ./ [3780.591819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/update_repo.sh [3780.591819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/mount_samba_shared.sh [3780.591819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/rename.sh [3780.591819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/a6o_gpl_headers.conf [3780.595819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/package_all.sh [3780.595819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/insert_gpl_headers.pl [3780.595819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/package.sh [3780.595819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/internal_use_only/create_sym_links.sh [3780.599819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/launch_deamon.sh [3780.599819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/configure.sh [3780.595819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/compile.sh [3780.595819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/.gitignore [3780.599819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/deb-src.sh [3780.603819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/launch_prelude_scan.sh [3780.603819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/build.sh [3780.603819] armadito[20855]: scanning file /home/uhuru/workspace/armadito/core/build/linux/scripts/launch_httpd.sh

vhamon avatar Feb 23 '17 14:02 vhamon

The daemon should check that the path is absolute and return an error if not. The CLI should transform relative paths passed as arguments to absolute paths.

fdechelle avatar Feb 23 '17 14:02 fdechelle

Where can I download the Windows version? Some English sites have screenshots, but I can’t find them anywhere. Forgive me for the off-topic question.

mrkaban avatar Nov 09 '19 13:11 mrkaban