armada icon indicating copy to clipboard operation
armada copied to clipboard

Make deserializing Service/Ingress types more strict

Open JamesMurkin opened this issue 3 years ago • 0 comments

Currently if you submit an Service/Ingress type which is an int but invalid, it just uses the first type

I.e if you say I want ServiceType with value 100, you get NodePort (as NodePort is the first ServiceType)

  • Even though value 100 is invalid, as the only options are 0 and 1

This will prevent users relying on invalid numbers that may at some point become used and also it is probably just good practice to not support invalid values and default them

  • Now the user will get an api error back immediately

JamesMurkin avatar Jan 28 '22 10:01 JamesMurkin