armada icon indicating copy to clipboard operation
armada copied to clipboard

WIP: Fix armada-airflow build

Open Sovietaced opened this issue 1 year ago • 2 comments

… builds

Fixes #

Special notes for your reviewer:

Sovietaced avatar May 24 '24 22:05 Sovietaced

@Sovietaced We expect that the new query API in Armada will be imminent, and the Airflow projects will be switching to using that, and will retire the old Job Service service. Likely this PR may be obsolete in the near future.

richscott avatar Jun 11 '24 19:06 richscott

@Sovietaced We expect that the new query API in Armada will be imminent, and the Airflow projects will be switching to using that, and will retire the old Job Service service. Likely this PR may be obsolete in the near future.

This PR is about fixing the armada-airflow build. I don't think its related to the old jobs service at all. There has been a fix for the armada-airflow build here, but the approach is not ideal considering it locks users of armada-airflow to a specific version of grpcio. Libraries pinning dependencies is an anti pattern imo. Applications should pin dependencies, libraries should not.

Sovietaced avatar Jun 11 '24 19:06 Sovietaced

@Sovietaced our armada-airflow users have made a PR that indicates they are experiencing an incompatibility with the later versions of grpcio in using opentelemetry with airflow - see https://github.com/armadaproject/armada/pull/3631/files

richscott avatar Jul 09 '24 19:07 richscott

@Sovietaced our armada-airflow users have made a PR that indicates they are experiencing an incompatibility with the later versions of grpcio in using opentelemetry with airflow - see #3631 (files)

Yes, I am aware: https://github.com/open-telemetry/opentelemetry-python/pull/3931

Sovietaced avatar Jul 09 '24 19:07 Sovietaced