armada icon indicating copy to clipboard operation
armada copied to clipboard

CI: Fix warnings & deprecation messages in the workflows and enable DependaBot for GitHub actions

Open ljubon opened this issue 11 months ago • 0 comments

What type of PR is this?

CI: Resolve deprecation & warning messages in workflows Enable DependaBot for GitHub actions

What this PR does / why we need it:

Node16 has been out of support since September 2023. - more info in the post

  • Add GitHub actions for DependaBot (commit)
  • Bump the steps where deprecation/warnings are shown in the job (commit)

Optional

  • 🛠️ Proposed action: Open a PR which bump the version in this step which is used in Slack CI Alerts workflow and currently doesn't address this issue

Which issue(s) this PR fixes:

Fixes https://github.com/G-Research/gr-oss/issues/586


Testing results

As the desired state is that a job should run without warnings/deprecation messages shown, in this commit I removed some of the conditions in Armada workflow to test all workflows and their actions and below is the results for each workflow where deprecation warnings are shown

FAILED (need action update) 🟠

Slack CI Alerts

  • https://github.com/gr-oss-devops/armada/actions/runs/8267491233
  • The action which is used in Slack CI Alerts workflow Mo-Fatah/ci-alerts@v2 within the latest version doesn't address Node 16 deprecations warnings

PASSED 🟢

CI / Build / Tests / Lint

  • https://github.com/gr-oss-devops/armada/actions/runs/8265965699

Python Client

  • https://github.com/gr-oss-devops/armada/actions/runs/8265768402

Python Airflow Operator

  • https://github.com/gr-oss-devops/armada/actions/runs/8265768780

CodeQL

  • https://github.com/gr-oss-devops/armada/actions/runs/8266493895

Release Armada components (workflow failed due to missing tag, but no deprecated/warnings are shown)

  • https://github.com/gr-oss-devops/armada/actions/runs/8266493897/job/22614586618

Release Armada components - RC (workflow failed due to missing tag, but no deprecated/warnings are shown)

  • https://github.com/gr-oss-devops/armada/actions/runs/8266609054

Check required jobs (workflow failed due to missing ref, but no github/scripts@v7 showed there is no warnings/deprecatations)

  • https://github.com/gr-oss-devops/armada/actions/runs/8267125552/job/22616764587

ljubon avatar Mar 15 '24 11:03 ljubon