armada icon indicating copy to clipboard operation
armada copied to clipboard

[Pulsar Scheduler] Better Logging And Fix Warnings

Open d80tb7 opened this issue 2 years ago • 1 comments

  • Ensure we log a stacktrace when logging errors
  • Special TabWriter backed by a StringBuilder that guarantees not to throw errors (fixes a load of warning where we throwing lots of errors away).
  • Fixes various typos

┆Issue is synchronized with this Jira Task by Unito

d80tb7 avatar Mar 07 '23 07:03 d80tb7

Codecov Report

Attention: Patch coverage is 30.71895% with 106 lines in your changes missing coverage. Please review.

Project coverage is 58.43%. Comparing base (e721b8f) to head (7eb452a). Report is 1091 commits behind head on master.

Files with missing lines Patch % Lines
internal/scheduler/reports.go 25.53% 35 Missing :warning:
internal/scheduler/scheduler.go 10.52% 17 Missing :warning:
internal/scheduler/legacyscheduler.go 0.00% 15 Missing :warning:
internal/scheduler/submitcheck.go 0.00% 11 Missing :warning:
internal/common/logging/stacktrace.go 0.00% 10 Missing :warning:
internal/scheduler/nodedb.go 37.50% 10 Missing :warning:
internal/scheduler/metrics.go 0.00% 3 Missing :warning:
internal/scheduler/schedulerapp.go 0.00% 3 Missing :warning:
internal/scheduler/leader.go 0.00% 1 Missing :warning:
internal/scheduler/schedulerobjects/executor.go 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2231      +/-   ##
==========================================
- Coverage   58.55%   58.43%   -0.13%     
==========================================
  Files         227      228       +1     
  Lines       28293    28411     +118     
==========================================
+ Hits        16568    16601      +33     
- Misses      10448    10512      +64     
- Partials     1277     1298      +21     
Flag Coverage Δ
armada-server 58.43% <30.71%> (-0.13%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 07 '23 08:03 codecov[bot]