armada
armada copied to clipboard
docs: document preemption in Armada
I'd prefer moving the docs for preemption config into the config itself (that includes everything except the example job). I.e., put it in the PreemptionConfig
definition in the code. That way we ensure the code and docs are in synch. Creating standalone docs runs the risk of the docs becoming outdated without us noticing. For a mature project, that's less of an issue. Since there are fewer changes. But for Armada there are lots of changes.
Re the example job. I think it's better we but it into the user guide.
I think it looks good but I can get behind Albin's suggestion. Example yaml might be better as standalone file which we can just directly submit to armada if wanted.
I think the config comments and examples look good. I was hoping to see a design of how we implemented Preemption in Armada.
I'd like to also see what the problems were with the current premption API so we can potentially bring this to the Kubernetes project as a potential feature request or fix.
@kannon92 most probably the backoffice side of Preemption will get completely redesigned soon, so current diagrams won't be relevant, but the client-facing interface will remain the same.
I plan on updating the docs as soon as preemption is redesigned