armada icon indicating copy to clipboard operation
armada copied to clipboard

Make CancelJobSet event set cancelling user

Open JamesMurkin opened this issue 2 years ago • 1 comments

Currently CancelJobSet event messages do not contain the user id of the user who perform the cancellation.

That means cancellation events populate the user id with the queue name.

It is useful to know who cancelled things, for auditing purposes.

This line https://github.com/G-Research/armada/blob/b14170a59b43996d26167141d6dee774f67b0c47/internal/armada/server/submit_from_log.go#L509 shows where we set the user id as the queue name. As a starting point to where this issue needs to be fixed

JamesMurkin avatar Aug 05 '22 16:08 JamesMurkin

Hey team! Please add your planning poker estimate with ZenHub @dejanzele @jayofdoom @kannon92 @richscott

dave-gantenbein avatar Aug 09 '22 13:08 dave-gantenbein