armada icon indicating copy to clipboard operation
armada copied to clipboard

Published 20 hours ago • verified publisher icon armadaproject

Propose a set of linters for Armada

Open dejanzele opened this issue 2 years ago • 3 comments

dejanzele avatar Jul 12 '22 15:07 dejanzele

Is this related https://github.com/G-Research/armada/issues/659?

kannon92 avatar Jul 12 '22 18:07 kannon92

My recomendation for running lint pass would be to use golangci-lint -

My recomendation would be to use the following linters in Armada:

  • gofumpt - linter on common Golang coding conventions
  • lll - linter for long lines
  • go-critic - static code analysis for bugs
  • staticcheck - amazing static code analysis, code simplification, bugs

Here is a nice post on amazing Golang linters - https://github.com/golangci/awesome-go-linters

dejanzele avatar Aug 09 '22 14:08 dejanzele

This one is interesting: https://github.com/lafolle/flen

dave-gantenbein avatar Aug 09 '22 18:08 dave-gantenbein

https://github.com/G-Research/armada/pull/1362

We can close as this is complete. This is a WIP as we have a lot of failures if we include linters.

kannon92 avatar Aug 23 '22 15:08 kannon92