build fails on linux if TESTS_IN_DOCKER isn't set

[andrewpcone]

make proto should work out of the box. Right now it doesn't, because TESTS_IN_DOCKER isn't set, which makes GO_TEST_CMD empty, which causes swagger and other commands to run on the host, rather than in docker. If the user's PATH doesn't include ~/go/bin or other $GOPATH/bin, then swagger fails.

I propose that we build exclusively in docker by using $GO_CMD in front of all the make proto commands instead of relying on the system go installation.

[andrewpcone]

alternatively we can have the makefile call, for example, `go env GOPATH`/swagger or similar

[kannon92]

Could someone reproduce this? Not sure if it’s fixed or not.

[Sharpz7]

Since we now use mage, this isn't needed. Closing