async-stripe icon indicating copy to clipboard operation
async-stripe copied to clipboard

Add "create promotion code" API

Open TmLev opened this issue 1 year ago • 6 comments

Summary

This PR enables users of async-stripe to create promotion codes.

I needed to programmatically create a lot of promotion codes, and since I couldn't find a way to achieve this with async-stripe, I've added it manually.

Checklist

  • [x] ran cargo make fmt
  • [x] using conventional commits to hightlight user-facing fixes and features

TmLev avatar Aug 11 '24 21:08 TmLev

Now that I look at it, I don't feel like this API should be a part of the checkout feature. Where should we put it though?

TmLev avatar Aug 11 '24 21:08 TmLev

Now that I look at it, I don't feel like this API should be a part of the checkout feature. Where should we put it though?

Stripe seems to put it under "products". So maybe can be under #[cfg(feature = "products")]?

augustoccesar avatar Aug 12 '24 06:08 augustoccesar

So maybe can be under #[cfg(feature = "products")]?

Great idea! Done.

TmLev avatar Aug 13 '24 20:08 TmLev

@arlyon a kind ping – reviewing this shouldn't take longer than two minutes of your time :)

TmLev avatar Aug 23 '24 20:08 TmLev

Running CI

arlyon avatar Aug 23 '24 20:08 arlyon

CI / verify-codegen (pull_request) Failing after 57s

Not sure this particular PR has anything to do with the codegen?.. Please correct me if I'm wrong

TmLev avatar Aug 23 '24 21:08 TmLev

@arlyon is there anything I can do to help you with the pipeline?

TmLev avatar Aug 30 '24 16:08 TmLev

No that task is broken, haven't had a chance to look at it. Merged! New release should pop up soon (and leave a comment here).

arlyon avatar Aug 31 '24 11:08 arlyon

:tada: This PR is included in version 0.39.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

arlyon avatar Aug 31 '24 11:08 arlyon