marlin icon indicating copy to clipboard operation
marlin copied to clipboard

Fix and update dependencies to 0.3

Open vlopes11 opened this issue 2 years ago • 2 comments

Description

The branch constraints isn't building with latest dependencies.

Open questions

  • [ ] We declare DensePolynomial<F> concretely in some places, and expect the generic PC::BatchProof in others
  • [ ] fiat_shamir::AlgebraicSponge looks duplicate to ark_sponge::CryptographicSponge and should possibly be replaced

closes: #87


  • [ ] Targeted PR against correct branch (master) - N/A, this aims to fix constraints so the latter can be merged to master
  • [x] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • [ ] Wrote unit tests
  • [ ] Updated relevant documentation in the code
  • [ ] Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • [x] Re-reviewed Files changed in the Github PR explorer

vlopes11 avatar Mar 23 '22 15:03 vlopes11

We should indeed deprecate fiat_shamir::AlgebraicSponge entirely

Pratyush avatar Mar 23 '22 15:03 Pratyush

ideas to fix the test?

weikengchen avatar Mar 27 '22 01:03 weikengchen