marlin icon indicating copy to clipboard operation
marlin copied to clipboard

Constraints

Open npwardberkeley opened this issue 3 years ago • 8 comments

npwardberkeley avatar Oct 27 '20 21:10 npwardberkeley

update: currently debugging on an unsatisfied PC check using tracing.

weikengchen avatar Nov 12 '20 16:11 weikengchen

Note: This branch uses the constraints branch of poly-commit. Once poly-commit's PR is merged, this part needs to be changed.

weikengchen avatar Nov 12 '20 18:11 weikengchen

(Help needed. The no_std error seems weird, though ci.yml for this branch has been updated.)

weikengchen avatar Nov 12 '20 19:11 weikengchen

Merging with the additional conflicts with the fix to the main branch...

weikengchen avatar Nov 13 '20 00:11 weikengchen

btw, is it possible to have a "reviewing" guide here? Which parts should I focus on, which parts are "trivial", etc.

Ditto for poly-commit.

This can be as simple as leaving comments on the files that need most scrutiny.

Pratyush avatar Nov 13 '20 01:11 Pratyush

No problem. Will do for both.

weikengchen avatar Nov 13 '20 01:11 weikengchen

Thanks, much appreciated =)

Pratyush avatar Nov 13 '20 01:11 Pratyush

(We would pause here and leave the changes in the constraints branch, and we will come back after the paper deadline.)

weikengchen avatar Nov 17 '20 22:11 weikengchen