gemini icon indicating copy to clipboard operation
gemini copied to clipboard

[Gemini] update deps and resolve small compile errors

Open z-tech opened this issue 1 year ago • 2 comments

Synopsis:

First I noticed gemini -> main compile fails:

error: failed to load source for dependency `ark-ec`

Caused by:
  Unable to update https://github.com/mmaker/algebra?branch=feature/additive-groups#1419b95a

Then I noticed the PR merged on May 10, 2023 arkworks-rs/algebra <- feature/additive-groups

I updated cargo.toml to point to arkworks-rs/algebra -> main and resolved some tiny type errors like these:

fn advance_by(&mut self, n: usize) -> Result<(), usize> {
                                            ^^^^^^^^^^^^^^^^^
                                            expected `core::num::NonZeroUsize`, found `usize`
                                            help: change the output type to match the trait: `core::result::Result<(), core::num::NonZeroUsize>`

Result:

  • no compile errors for cargo test, cargo rustdoc --open, cargo run --features asm,print-trace,parallel --example snark -- -i 4
  • tests pass, benches work

z-tech avatar Oct 04 '23 14:10 z-tech

Hello! thank you so much, indeed part of the work here was based on PR's that are now merged in arkworks. I think we can update them once ark-group exists. What do you think?

I think the remaining issues are only minor rust updates.

mmaker avatar Oct 11 '23 12:10 mmaker

Sorry for the delay. This of course sounds good to me 😛

z-tech avatar Nov 13 '23 15:11 z-tech