crypto-primitives
crypto-primitives copied to clipboard
Implementation of `CryptographicSponge` for Merlin
Using Merlin, we have the possibility of having a sponge that is not generic on a field.
Before we can merge this PR, please make sure that all the following items have been checked off. If any of the checklist items are not applicable, please leave them but write a little note why.
- [ ] Targeted PR against correct branch (main)
- [ ] Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
- [ ] Wrote unit tests
- [ ] Updated relevant documentation in the code
- [ ] Added a relevant changelog entry to the
Pending
section inCHANGELOG.md
- [ ] Re-reviewed
Files changed
in the Github PR explorer
@hdevalence
I had to remove the redundant imports since cargo +nightly check
complained. Specifically, Vec
is in the prelude and is redundant to import.
@autquis ah yes see also this PR: https://github.com/arkworks-rs/algebra/pull/790 to tackle the same sort of issues in algebra
Edit: I actually wonder why this works, given that similar changes in poly commit failed no-std
@mmagician I didn't understand what I should fix in arkworks-rs/algebra#790? As it is merged already.
Why it works: I guess because it is not completely no-default-features
and r1cs
is enabled. This is the command for no_std check:
cargo build --no-default-features --features=r1cs --target aarch64-unknown-none
What I meant is that the algebra PR addressed similar issues.
A gentle ping :)