circom-compat icon indicating copy to clipboard operation
circom-compat copied to clipboard

Published 20 hours ago • verified publisher icon arkworks-rs

Move parts to `ark-groth16`?

Open Pratyush opened this issue 2 years ago • 2 comments

Hey @gakonst!

With PR https://github.com/arkworks-rs/groth16/pull/44, it is possible to specify the R1CSToQAP reduction directly on the Groth16 type. Would it make sense to upstream the CircomReduction to ark-groth16 so that the logic lives there?

Happy to discuss moving other parts that make sense, and also to adopt this repo in the arkworks-rs org also, if that's something you'd want.

Pratyush avatar Feb 03 '23 03:02 Pratyush

Oh yes, that would be awesome. Let's do it, happy to integrate as many parts of ark-circom in the core ecosystem as would make sense. A little stretched on time personally, but happy to review code if anyone takes up the task.

gakonst avatar Feb 03 '23 06:02 gakonst

Awesome, maybe a good starting point would be the CircomReduction move; do you want to make a PR for that?

Pratyush avatar Feb 03 '23 07:02 Pratyush