bluez-alsa icon indicating copy to clipboard operation
bluez-alsa copied to clipboard

update dbus config documentation

Open borine opened this issue 9 months ago • 4 comments

Try to improve the description of locations for the bluealsa service d-bus policy file.

borine avatar May 22 '24 13:05 borine

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.18%. Comparing base (9d73103) to head (e43c912).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #709      +/-   ##
==========================================
+ Coverage   68.16%   68.18%   +0.01%     
==========================================
  Files          95       95              
  Lines       15293    15293              
  Branches     2428     2428              
==========================================
+ Hits        10425    10427       +2     
+ Misses       4753     4751       -2     
  Partials      115      115              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 22 '24 14:05 codecov[bot]

I've just checked files in /usr/share/dbus-1/system.d/ on my Debian host, and there is a lot of files which names correspond to D-Bus service name. What do you think about renaming bluealsa.conf to org.bluealsa.conf?

See "INTEGRATING SYSTEM SERVICES" in: https://dbus.freedesktop.org/doc/dbus-daemon.1.html :

The policy file for com.example.Example1 should normally be named com.example.Example1.conf.

arkq avatar May 22 '24 17:05 arkq

What do you think about renaming bluealsa.conf to org.bluealsa.conf?

I think that is the "correct" name. The only backwards compatibility issue I can see with changing the name is when an update results in two copies under different names (and also cross-release documentation such as the wiki, but that can be dealt with). So in principle I am in favour of such a change.

borine avatar May 22 '24 18:05 borine

The only backwards compatibility issue I can see with changing the name is when an update results in two copies under different names

I think that in the next release we can go with exec renames (I'll submit PR proposal in few days maybe), so we can do more "destructive" stuff as well :D

arkq avatar May 22 '24 18:05 arkq