Arkadiy Paronyan
Arkadiy Paronyan
> This pr introduces a trie level cache and removes the old state cache. As seen on a lot of parachains the state cache was/is buggy: https://github.com/paritytech/cumulus/issues/474 Is this issue...
Thank you for the PR! Consider adding your polkadot address in the format described [here](https://github.com/paritytech/substrate-tip-bot#pull-request-body). For now I only took a basic look and it looks mostly good. There's just...
> I have also checked the upper callers that required RefWindow::have_block but it seems hard to remove DbBacked::hashs without other ways to determine if a block is canonicalized (then we...
`is_pruned` and `pin` already check if the block is in the non-canonicalized overlay by calling `NonCanonicalOverlay::have_block`. Not to be confused with `RefWindow::have_block`. That's a different `have_block` function and there's no...
After some consideration I can see that is_pruned/pin is still a bit problematic, considering that the caller ineed does not know when the hash is taken into account or the...
> pin is implemented a bit differently, because pin need to pin the block according to the have_block result immediately, so we can't return a MaybePin to the caller to...
Is `0xcc5b95fe2c408170bb864c5f13f84d77fa9fe4c562650c9985f4850425d9f5a7` in the finalized chain?
It matters because there are two possible reasoins for this message. 1. Block is too old and discarded because of pruning, as @bkchr sugggests 2. Block was discarded because it...
cc @bkchr