ng-sidebar icon indicating copy to clipboard operation
ng-sidebar copied to clipboard

Sidebar does not close on iOS since 7.3.0

Open acuntex opened this issue 7 years ago • 2 comments

We recently upgraded to Angular 6 and also upgraded ng-sidebar.

We noticed that the sidebar does not close and is not clickable at all on iOS (iPhone).

After trying out older versions, we figured out that the behavior started in V7.3.0, so it must be one of those changes: https://github.com/arkon/ng-sidebar/compare/v7.2.1...v7.3.0

Here is the version with 7.2.1: www.neobirdgames.com Here is the version with 7.3.0 (would be the same with 8.0.0): beta.neobirdgames.com

The code looks like this:

<ng-sidebar-container #sideBarContainer [ngClass]="{'ng-content-padding-fix': !appService.gameInfo}">
  <ng-sidebar #sideBar *ngIf="isHiddenLayout" position="right" mode="over" class="platformMenu mobile-side-bar" (onClosed)="menuClosed()" [(opened)]="sideBarService.opened" autoFocus="false" [showBackdrop]="true" [closeOnClickBackdrop]="true">
    <platform-menu-button (onSideBarSlide)="onSideBarSlide($event)"></platform-menu-button>
    <div class="platform-content" (swiperight)="onSwipeRightMobile()">
      <platform-content></platform-content>
    </div>
  </ng-sidebar>
...
</ng-sidebar-container>

I honestly cannot imagine any logical explanation how the changes made in 7.3.0 could be responsible for a bug, but then again: It's only on iOS Safari, so logic is probably not the best tool ;-)

acuntex avatar Aug 23 '18 11:08 acuntex

I honestly can't see why any of those changes would affect it either...

arkon avatar Aug 30 '18 02:08 arkon

Since code as been moved to the end of the method, might there be a chance, that this could be the cause (like more changes on iOS or some race condition)?

acuntex avatar Sep 03 '18 11:09 acuntex