Arko Dasgupta
Arko Dasgupta
thanks for surfacing this * needs to be fixed in https://github.com/envoyproxy/gateway/blob/d383ba54020a1bd38e2787eff230b055713f35e3/internal/gatewayapi/route.go#L991 * and in https://github.com/envoyproxy/gateway/blob/d383ba54020a1bd38e2787eff230b055713f35e3/internal/gatewayapi/route.go#L859
thanks for unifying all the logic here @shawnh2 ! I'm a +1 on @zirain's idea of moving the status pieces under `/internal/gatewayapi/status` since they are all tied to GWAPI resources...
@dboslee long lived connections might be a separate sub issue related to keep alive timeouts (currently disabled by default)
Hi @Ronnie-personal thanks for the looking into this issue, assigning this you for now * a good test to add would be a `Reload` test where we reload Envoy Gateway...
hey @Ronnie-personal that looks right ! updating some steps Obtain Kubernetes client from cSuite 1. Use the client to get Envoy Proxy service by name 'proxy-config' and namespace 'envoy-gateway-system' (e.g...
thanks for highlighting this @dboslee ! as @Ronnie-personal pointed out, we do incorporate the route name in the tcp listener (refer to https://github.com/envoyproxy/gateway/pull/696) since the tcp listener directly maps to...
* this is the right approach @Ronnie-personal, you can skip comparison of some fields using `cmp.Diff` which we use in this project, [here's](https://github.com/envoyproxy/gateway/blob/634ccdb4d7d9967072fd75815119ef7c203dc08f/internal/gatewayapi/translator_test.go#L106C1-L106C1) an example. from the above image, it...
hey @Ronnie-personal thanks for continuing to work on this, can you raise this as a PR so others in the community can also review, tia !
this was discussed in the meeting today * there's currently nothing in the spec defined in the ExtensionManager config https://github.com/envoyproxy/gateway/blob/cc01bf5ea9e962f82314d85e84b7a00b8314a34c/api/v1alpha1/envoygateway_types.go#L398 that talks about the context sent per hook for a...
-1 to adding any extension manager related logic to `ClientTrafficPolicy` which is tied to the `platform admin` / `app admin` persona where's the ExtensionManager is tied to a `vendor` /...