api-key-auth
api-key-auth copied to clipboard
Update parser.js
added Check if "required headers" param not exists use the date HTTP header by default
Codecov Report
Merging #8 (0479015) into master (93ed511) will decrease coverage by
0.81%. The diff coverage is75.00%.
@@ Coverage Diff @@
## master #8 +/- ##
===========================================
- Coverage 100.00% 99.18% -0.82%
===========================================
Files 5 5
Lines 120 123 +3
===========================================
+ Hits 120 122 +2
- Misses 0 1 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/parser.js | 98.03% <75.00%> (-1.97%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 93ed511...0479015. Read the comment docs.
Hi thanks for you PR. The required headers are the headers present in the Authorization header. If the header parameters isn't present on the signature, we use the date header. Your PR is to force a signature to use a list of headers ? For exemple, the signature must always use date and host headers ?
Codecov Report
Merging #8 (0479015) into master (93ed511) will decrease coverage by
0.81%. The diff coverage is75.00%.
:exclamation: Current head 0479015 differs from pull request most recent head 23c8ec7. Consider uploading reports for the commit 23c8ec7 to get more accurate results
@@ Coverage Diff @@
## master #8 +/- ##
===========================================
- Coverage 100.00% 99.18% -0.82%
===========================================
Files 5 5
Lines 120 123 +3
===========================================
+ Hits 120 122 +2
- Misses 0 1 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| lib/parser.js | 98.03% <75.00%> (-1.97%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 93ed511...23c8ec7. Read the comment docs.