api-key-auth icon indicating copy to clipboard operation
api-key-auth copied to clipboard

Update parser.js

Open michaelpiper opened this issue 4 years ago • 3 comments

added Check if "required headers" param not exists use the date HTTP header by default

michaelpiper avatar Mar 26 '21 20:03 michaelpiper

Codecov Report

Merging #8 (0479015) into master (93ed511) will decrease coverage by 0.81%. The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master       #8      +/-   ##
===========================================
- Coverage   100.00%   99.18%   -0.82%     
===========================================
  Files            5        5              
  Lines          120      123       +3     
===========================================
+ Hits           120      122       +2     
- Misses           0        1       +1     
Impacted Files Coverage Δ
lib/parser.js 98.03% <75.00%> (-1.97%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93ed511...0479015. Read the comment docs.

codecov-io avatar Mar 26 '21 20:03 codecov-io

Hi thanks for you PR. The required headers are the headers present in the Authorization header. If the header parameters isn't present on the signature, we use the date header. Your PR is to force a signature to use a list of headers ? For exemple, the signature must always use date and host headers ?

arkerone avatar Mar 29 '21 13:03 arkerone

Codecov Report

Merging #8 (0479015) into master (93ed511) will decrease coverage by 0.81%. The diff coverage is 75.00%.

:exclamation: Current head 0479015 differs from pull request most recent head 23c8ec7. Consider uploading reports for the commit 23c8ec7 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##            master       #8      +/-   ##
===========================================
- Coverage   100.00%   99.18%   -0.82%     
===========================================
  Files            5        5              
  Lines          120      123       +3     
===========================================
+ Hits           120      122       +2     
- Misses           0        1       +1     
Impacted Files Coverage Δ
lib/parser.js 98.03% <75.00%> (-1.97%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93ed511...23c8ec7. Read the comment docs.

codecov-commenter avatar Sep 03 '21 20:09 codecov-commenter