elastic-apm-laravel icon indicating copy to clipboard operation
elastic-apm-laravel copied to clipboard

Published 20 hours ago • verified publisher icon arkaitzgarro

Laravel 9?

Open afiqiqmal opened this issue 3 years ago • 10 comments

Any plan to upgrade to Laravel 9?

afiqiqmal avatar Feb 10 '22 20:02 afiqiqmal

No plans yet. Di you try installing the package already? Any feedback you can share already?

arkaitzgarro avatar Feb 11 '22 08:02 arkaitzgarro 

 Problem 1
    - arkaitzgarro/elastic-apm-laravel[v3.0-RC1, ..., v3.0.8] require illuminate/database ^6 || ^7 || ^8 -> found illuminate/database[v6.0.0, ..., 6.x-dev, v7.0.0, ..., 7.x-dev, v8.0.0, ..., 8.x-dev] but these were not loaded, likely because it conflicts with another require.
    - Root composer.json requires arkaitzgarro/elastic-apm-laravel ^3.0 -> satisfiable by arkaitzgarro/elastic-apm-laravel[v3.0-RC1, ..., v3.0.8].

You can also try re-running composer require with an explicit version constraint, e.g. "composer require arkaitzgarro/elastic-apm-laravel:*" to figure out if any version is installable, or "composer require arkaitzgarro/elastic-apm-laravel:^2.1" if you know which you need.

I think its required to include Illuminate 9

afiqiqmal avatar Mar 06 '22 08:03 afiqiqmal

L9 also requires PHP 8+ (ditto for components, e.g. database) where's we require 7.3+, so we'd need to bump PHP requirement along with all else.

countless-integers avatar Mar 08 '22 07:03 countless-integers

@arkaitzgarro Is the PR for Laravel 9 done/safe to pull-in? Would love to get upgraded. Thanks.

https://github.com/arkaitzgarro/elastic-apm-laravel/pull/157

jplata avatar Jul 07 '22 15:07 jplata

@arkaitzgarro Is the PR for Laravel 9 done/safe to pull-in? Would love to get upgraded. Thanks.

#157

Hey @jplata,

I managed to make the unit tests pass in the L9 branch, but I don't have any Laravel application where I could test the package. If I create a RC, would you be able to give it a try?

arkaitzgarro avatar Jul 09 '22 15:07 arkaitzgarro

That would be great to try out, thanks.

jplata avatar Jul 13 '22 12:07 jplata

@jplata I created a BETA tag, please give it a try and let me know if it works 🤞

arkaitzgarro avatar Jul 14 '22 16:07 arkaitzgarro

@jplata What is the stand on this?

snake-py avatar Aug 01 '22 10:08 snake-py

So we tried the BETA tag and it seems to work up to Larafvel 9.22 now with Laravel 9.25 I am getting composer error again.

snake-py avatar Aug 17 '22 14:08 snake-py

So we tried the BETA tag and it seems to work up to Larafvel 9.22 now with Laravel 9.25 I am getting composer error again.

Can you share the specific error you are seeing?

arkaitzgarro avatar Aug 17 '22 15:08 arkaitzgarro

So we tried the BETA tag and it seems to work up to Larafvel 9.22 now with Laravel 9.25 I am getting composer error again.

I installed the beta in a project with Laravel 9.34, and so far so good, no errors when installing the package.

arkaitzgarro avatar Oct 06 '22 13:10 arkaitzgarro

@arkaitzgarro oh I forgot to answer. Yes the issues we have seen did not relate to this package. Sorry for the false alarm

snake-py avatar Oct 06 '22 18:10 snake-py