Arek Burdach

Results 32 comments of Arek Burdach

> > > Hi @arkadius I have started working in backporting the RANGE distribution to the IcebergSink. The unit tests in my code will benefit from the new marker interface...

Hi @rodmeneses. No, this change is not relevant. I'll close it.

@rodmeneses , @pvary please have a look at this PR. In the change, I added the configuration option that we talked about. I also added the documentation. In the docs...

> This is still a draft, as I have no idea how to show in unit tests, that this configuration option does anything 😅. I've only checked in the debugger...

@rodmeneses @pvary I've done all fixes that were discussed in comments. Can we move forward with this change? Do we need more eyes to take a look at the docs...

I think that this option would benefit this project in a good transitional migration to the new interface in Table API / Flink SQL. What is the alternative plan for...

> @arkadius: Could you please make sure the tests are run? Just change the commit message of the last commit and force push the branch, or something? Sure, I rebased...

> @arkadius: Could you please backport the change to the relevant older Flink branches? Sure, here is backport for Flink 1.19: #11665 The SinkV2 API was added in Flink 1.19...

> This one looks good to me. @pvary could you please add me as reviewer so I can register my approval ? Thanks @pvary can you add @rodmeneses as a...