uSpeech icon indicating copy to clipboard operation
uSpeech copied to clipboard

Update library types to fixed length types

Open arjo129 opened this issue 10 years ago • 6 comments

With variations in various boards, it seems necessary to update the library to used u_int16t rather than int. (which was bad practice).

arjo129 avatar May 21 '14 01:05 arjo129

Hello. Is someone out there?

q2dg avatar Sep 06 '16 22:09 q2dg

Hi, what would you like to know?

arjo129 avatar Sep 07 '16 00:09 arjo129

Hi! If this issue has been resolved. Thanks

q2dg avatar Sep 07 '16 00:09 q2dg

No it hasn't been resolved.

arjo129 avatar Sep 07 '16 00:09 arjo129

Hello! I went ahead and made changes to the uspeech.h file so that it contains u_int16t types instead of int. I also included the appropriate library. I wanted to add a message here because this issue seems a bit dated and I am new to helping in open source projects. In other words I just wanted to confirm that I was helping in an existing issue and that I didnt break anything.

gonzalj3 avatar Feb 25 '17 17:02 gonzalj3

Yep thanks I'll take a look at the PR just give me a day or two, bit busy. In future you can reference you're pull request by mentioning the pull request number like so #PRnum #44. Cheers!

arjo129 avatar Feb 26 '17 00:02 arjo129