ssb-browser-demo icon indicating copy to clipboard operation
ssb-browser-demo copied to clipboard

profile editor too big

Open arj03 opened this issue 4 years ago • 4 comments

image

manage to capture this one now @KyleMaas. It happened when I started a new private chrome session, did manual and just navigated to the new profile.

arj03 avatar Jul 06 '21 21:07 arj03

Ah. Okay...that's going to be an interesting one to try to track down.

KyleMaas avatar Jul 06 '21 21:07 KyleMaas

This one may or may not be worth fixing right now - looks like they're having other problems with things exceeding the bounds of the editor. See:

https://github.com/nhn/tui.editor/issues/1633

https://github.com/nhn/tui.editor/issues/1627

KyleMaas avatar Jul 06 '21 21:07 KyleMaas

As far as I can tell, we would need to call classifyToolbarItems somehow:

https://github.com/nhn/tui.editor/blob/3983510e871bf4cfdd98131a45e447d8cad1fd86/apps/editor/src/ui/components/toolbar/toolbar.ts#L192

There are several things that call that, but I think considering it looks like they're going to have to do some work on overflow anyway that it's probably not worth adding a hacky solution that'll likely break in a newer version.

KyleMaas avatar Jul 06 '21 21:07 KyleMaas

Agree, lets wait and see.

arj03 avatar Jul 07 '21 07:07 arj03