Anders Rune Jensen
Anders Rune Jensen
@mixmix I'm pretty sure that will also blow up. The problem is that JavaScript uses reference equality instead of value equality, which is what we want here. Using deepEqual should...
I'll whip up a comparer function. The objects are rather small as are the sets.
Great! I'm all for removing gotcha's. This is very much related to the documentation part of scuttlebot. While developing something for patchcore I changed my tactics to highlightning pain points...
Its quite hard to review a patch like this. There is so much condensed information in the module already. Probably needs to document the null thing in the README. One...
The tests are rather strange. They seem to actually [depend](https://github.com/ssbc/packet-stream/blob/bb0493dd0eb6454ac675df78dfed20e994a4881f/test/messages.js#L197) on this behaviour where values will be written [after](https://github.com/ssbc/packet-stream/blob/bb0493dd0eb6454ac675df78dfed20e994a4881f/test/messages.js#L181) a close. The output inside [read](https://github.com/ssbc/packet-stream/blob/bb0493dd0eb6454ac675df78dfed20e994a4881f/test/messages.js#L196) starts with end = true...
IE11 doesn't matter, it is dead anyway. Great how you collect info in this issue.
Strange. Have not seen that before. More likely that it lost it's local state of what feeds it know.
Agree, but lets get it all the features worked out so we have a better idea of what to aim for :)
I think so, it's still my favorite feature in browser demo :)