esrefactor
esrefactor copied to clipboard
ariya
Fix #7 and #8 - Detect function declaration as renamables AND make tests pass
I actually needed #7 to work, so I figured it was a good idea to also make #8 pass. By doing so I refactored a bit and tried to improve readability.
ariya won't merge your commits unless you squash them, and even then might not merge them. He still hasn't merged #9 which already fixed #7 and #8, and would have saved you from duplicating efforts.
@cakesmith Do you know if this repo is still maintained? (Your last comment somehow reads like PR wont get merged)
ariya only responded to my pull request asking me to squash commits 14 days ago but has never merged. I forked the repo and just used my own fork instead of waiting for him to fix his own code to pass his own tests. I also agree with making the tests standardized (maybe jasmine?)
On Mon, Oct 6, 2014 at 9:23 AM, Wolfram Kriesing [email protected] wrote:
@cakesmith https://github.com/cakesmith Do you know if this repo is still maintained? (Your last comment somehow reads like PR wont get merged)
— Reply to this email directly or view it on GitHub https://github.com/ariya/esrefactor/pull/10#issuecomment-58015778.
regarding jasmine - that would such a good thing. I just didn't want to make too big changes in one go :) so I did stick to existing the integration tests.
Also, the code should be rewritten to allow multiple refactors in one pass. I ended up just implementing another version of the same thing but an order of magnitude faster in another project, but I haven't had the time to rewrite this (which wouldn't be too hard, it's pretty small) yet. Especially if the owner is not willing to merge commits that fix his broken codebase.
I am in :)
Let me know where we can work together on it and I am in.
Just for your info, my actually feature requirement is only what the identify method does, imho rename should go into a separate thing.
I am currently using it in https://github.com/uxebu/ace-with-plugins which is part of https://github.com/uxebu/tddbin-frontend in order to implement a renaming refactoring feature for ace (and used in tddbin.com once implemented).