Flashbar icon indicating copy to clipboard operation
Flashbar copied to clipboard

Suggestion isShowing misleading name

Open AndreHaueisen opened this issue 6 years ago • 1 comments

Hi. First of all, I love Flashbar. You did a great job there.

I would like to make one suggestion. I think Flashbar.isShowing() is a bit misleading. You use it as an opposition to Flashbar.isDismissing(). Consider using the name Flashbar.isAppearing() or Flashbar.isEmerging() instead. It represents its functionality in a better way. Flashbar.isShowing() should substitute Flashbar.isShown() in my opinion.

Hope you take it into consideration. Cheers.

AndreHaueisen avatar May 13 '18 14:05 AndreHaueisen

Thanks for the suggestion. Flashbar.isAppearing() seems like a good name to go with. We can add it in the coming update.

aritraroy avatar May 14 '18 08:05 aritraroy