Notify icon indicating copy to clipboard operation
Notify copied to clipboard

Adding support for pinning notes or adding favorites

Open Kayvee08 opened this issue 2 years ago • 21 comments

Users can either pin notes that the deem important to the top or make then favorites which will also show those notes at the top.

Kayvee08 avatar Oct 22 '23 17:10 Kayvee08

Pin sounds better @Kayvee08

aritra-tech avatar Oct 22 '23 17:10 aritra-tech

With future tags system no needs for favorites. Just typing two-three labels in the search bar and find everything.

serrq avatar Oct 22 '23 18:10 serrq

So should we add option to pin (important) notes ?

Kayvee08 avatar Oct 22 '23 19:10 Kayvee08

Pinned notes feature brings important ones on top of the notes list. Makes sense for me.

Of course, first are the notes pinned, then those ordered according to the sorting criterion.

serrq avatar Oct 22 '23 19:10 serrq

WhatsApp Image 2023-10-23 at 00 49 40_cbc549e0

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.

Is the ideas feasible @Kayvee08 @serrq ?

aritra-tech avatar Oct 22 '23 19:10 aritra-tech

Like your idea. 👌

serrq avatar Oct 22 '23 19:10 serrq

What is the milestone for this feature? 1.6.0?

serrq avatar Oct 22 '23 19:10 serrq

What is the milestone for this feature? 1.6.0?

It will be 1.7.1 ig

aritra-tech avatar Oct 22 '23 19:10 aritra-tech

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

Kayvee08 avatar Oct 22 '23 19:10 Kayvee08

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

Same question. Good point.

serrq avatar Oct 22 '23 19:10 serrq

@aritra-tech currently we are showing the delete option in the top bar, so you are suggesting we move the option to pin and delete to the bottom bar right ?

Yeah right. What do you think is this idea good or you can tell what you want to do

aritra-tech avatar Oct 22 '23 19:10 aritra-tech

@aritra-tech bottomsheet is a good idea, but will see how others are incorporating this feature in terms of accessibility and UI.

Kayvee08 avatar Oct 22 '23 19:10 Kayvee08

Hey @serrq is the idea good to go that I have shared.

aritra-tech avatar Oct 22 '23 20:10 aritra-tech

Mmm I didn't understand your sentence. My English is so fragile. Might you change some words? You mean it is good sharing the ideas?

serrq avatar Oct 22 '23 20:10 serrq

WhatsApp Image 2023-10-23 at 00 49 40_cbc549e0

I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture.

Is the ideas feasible @Kayvee08 @serrq ?

This idea that I have told is okay for you? @serrq

aritra-tech avatar Oct 22 '23 20:10 aritra-tech

Excellent Aritra! 👌

serrq avatar Oct 22 '23 20:10 serrq

Hey @Kayvee08 then that's the final idea lets work on it. All the best

aritra-tech avatar Oct 22 '23 20:10 aritra-tech

Okay, will start working on it @aritra-tech

Kayvee08 avatar Oct 23 '23 04:10 Kayvee08

@aritra-tech worked on this and have added the PR https://github.com/aritra-tech/Notify/pull/214

Kayvee08 avatar Oct 27 '23 18:10 Kayvee08

is anybody looking into this ??, (Since #214 is not merged yet)

purushyb avatar Apr 25 '24 06:04 purushyb

No @purushyb if you want you can pick it up

aritra-tech avatar May 24 '24 03:05 aritra-tech

Hi @aritra-tech Can I look into this as well? Seems no one has provided an acceptable solution yet.

andy-ife avatar Oct 27 '24 17:10 andy-ife

yeah please @andy-ife

aritra-tech avatar Oct 27 '24 17:10 aritra-tech

Alright. Will keep you posted. Hoping to get my first gh contribution lol

andy-ife avatar Oct 27 '24 18:10 andy-ife

im already working on it

MianMuzammil67 avatar Oct 28 '24 09:10 MianMuzammil67

Hmm. What do you say @aritra-tech

andy-ife avatar Oct 28 '24 10:10 andy-ife

Hey @MianMuzammil67 sorry but @andy-ife is working on it @andy-ife please continue

aritra-tech avatar Oct 28 '24 17:10 aritra-tech

WhatsApp Image 2023-10-23 at 00 49 40_cbc549e0 I was thinking like this now on a long click there is a feature multi-delete option so I was thinking that when the user long clicks then a bottom sheet opens up with two features Delete & Pin as shown in the picture. Is the ideas feasible @Kayvee08 @serrq ?

This idea that I have told is okay for you? @serrq

@aritra-tech I'll go with this implementation if that's alright

andy-ife avatar Oct 30 '24 22:10 andy-ife

All done @aritra-tech . Pull request #540

andy-ife avatar Nov 01 '24 22:11 andy-ife

I will look into the changes and merge the PR @andy-ife Thank you

aritra-tech avatar Nov 02 '24 14:11 aritra-tech