dynamo-release icon indicating copy to clipboard operation
dynamo-release copied to clipboard

Linting and Formatting automation

Open AayushSabharwal opened this issue 2 years ago • 5 comments

  • Separate Flake8 into its own action, since it doesn't need to be run in a matrix of python versions and is independent of tests
  • Add .flake8 config to be in line with black formatting
  • Add action to check if code is formatted as per black standards
  • Format all code as per black
  • Flake8 action fails until all issues are resolved, to make sure that eventually they will be

If the formatting is acceptable, this can be used to ensure all commits/PRs are formatted appropriately. Ensuring the code is all as per flake8 can be done gradually.

AayushSabharwal avatar Aug 24 '22 12:08 AayushSabharwal

Flake8 errors are now down to ~1850

AayushSabharwal avatar Aug 27 '22 21:08 AayushSabharwal

Now down to 1491

AayushSabharwal avatar Sep 01 '22 20:09 AayushSabharwal

Down to 945!

AayushSabharwal avatar Sep 02 '22 20:09 AayushSabharwal

787 Errors now

AayushSabharwal avatar Sep 03 '22 09:09 AayushSabharwal

We have identified 769 remaining errors, but many of them would be resolved by upcoming pull requests that address docstring or formatting issues. Therefore, we will handle these errors later again, once those changes are submitted to the main branch.

Ukyeon avatar Mar 09 '23 22:03 Ukyeon