[BUG] - AL2023 with Graviton CPU prints incorrect CPU name

[daniejstriata]

btop 1.2.13 prints the CPU name as Pmuv3 on a host with a Graviton CPU running Amazon Linux 2023.

/proc/cpuinfo does not list the CPU name for the Graviton CPU:

→ cat /proc/cpuinfo 
processor	: 0
BogoMIPS	: 243.75
Features	: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs
CPU implementer	: 0x41
CPU architecture: 8
CPU variant	: 0x3
CPU part	: 0xd0c
CPU revision	: 1

processor	: 1
BogoMIPS	: 243.75
Features	: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs
CPU implementer	: 0x41
CPU architecture: 8
CPU variant	: 0x3
CPU part	: 0xd0c
CPU revision	: 1

The CPU name on a Graviton CPU from lscpu:

→ lscpu
Architecture:           aarch64
  CPU op-mode(s):       32-bit, 64-bit
  Byte Order:           Little Endian
CPU(s):                 2
  On-line CPU(s) list:  0,1
Vendor ID:              ARM
  BIOS Vendor ID:       AWS
  Model name:           Neoverse-N1
    BIOS Model name:    AWS Graviton2
    Model:              1
    Thread(s) per core: 1
    Core(s) per socket: 2
    Socket(s):          1
    Stepping:           r3p1
    BogoMIPS:           243.75
    Flags:              fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs
Caches (sum of all):    
  L1d:                  128 KiB (2 instances)
  L1i:                  128 KiB (2 instances)
  L2:                   2 MiB (2 instances)
  L3:                   32 MiB (1 instance)
NUMA:                   
  NUMA node(s):         1
  NUMA node0 CPU(s):    0,1
Vulnerabilities:        
  Gather data sampling: Not affected
  Itlb multihit:        Not affected
  L1tf:                 Not affected
  Mds:                  Not affected
  Meltdown:             Not affected
  Mmio stale data:      Not affected
  Retbleed:             Not affected
  Spec rstack overflow: Not affected
  Spec store bypass:    Mitigation; Speculative Store Bypass disabled via prctl
  Spectre v1:           Mitigation; __user pointer sanitization
  Spectre v2:           Mitigation; CSV2, BHB
  Srbds:                Not affected
  Tsx async abort:      Not affected

Info (please complete the following information):

• btop++ version: 1.2.13
• Binary: [static binary from release]
• Architecture: [aarch64]
• Platform: [Linux]
• (Linux) Kernel: 6.1.49-70.116.amzn2023.aarch64
• (OSX/FreeBSD) Os release version:
• Terminal used: gnome
• Font used: Fira code Nerdfont

Additional context

contents of `~/.config/btop/btop.log

2023/09/18 (21:34:59) | ===> btop++ v.1.2.13
2023/09/18 (21:34:59) | WARNING: get_cpuHZ() : Failed to read /sys/devices/system/cpu/cpufreq/policy and /proc/cpuinfo.

2023/09/19 (07:17:46) | ===> btop++ v.1.2.13
2023/09/19 (07:17:46) | WARNING: get_cpuHZ() : Failed to read /sys/devices/system/cpu/cpufreq/policy and /proc/cpuinfo.

2023/09/19 (07:38:36) | ===> btop++ v.1.2.13
2023/09/19 (07:38:36) | WARNING: get_cpuHZ() : Failed to read /sys/devices/system/cpu/cpufreq/policy and /proc/cpuinfo.

2023/09/19 (07:42:30) | ===> btop++ v.1.2.13
2023/09/19 (07:42:30) | WARNING: get_cpuHZ() : Failed to read /sys/devices/system/cpu/cpufreq/policy and /proc/cpuinfo.

2023/09/19 (07:48:15) | ===> btop++ v.1.2.13
2023/09/19 (07:48:15) | DEBUG: Starting in DEBUG mode!
2023/09/19 (07:48:15) | INFO: Logger set to DEBUG
2023/09/19 (07:48:15) | DEBUG: Setting LC_ALL=C.UTF-8
2023/09/19 (07:48:15) | INFO: Running on /dev/pts/12
2023/09/19 (07:48:20) | INFO: Quitting! Runtime: 00:00:05

2023/09/19 (07:51:28) | ===> btop++ v.1.2.13
2023/09/19 (07:51:28) | DEBUG: Starting in DEBUG mode!
2023/09/19 (07:51:28) | INFO: Logger set to DEBUG
2023/09/19 (07:51:28) | DEBUG: Setting LC_ALL=C.UTF-8
2023/09/19 (07:51:28) | INFO: Running on /dev/pts/12
2023/09/19 (07:51:34) | WARNING: get_cpuHZ() : Failed to read /sys/devices/system/cpu/cpufreq/policy and /proc/cpuinfo.
2023/09/19 (07:51:40) | INFO: Quitting! Runtime: 00:00:12

[imwints]

Can you post the contents of /proc/cpuinfo, if the file is accessible?

[daniejstriata]

It is accessible:

cat /proc/cpuinfo

processor	: 0
BogoMIPS	: 243.75
Features	: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs
CPU implementer	: 0x41
CPU architecture: 8
CPU variant	: 0x3
CPU part	: 0xd0c
CPU revision	: 1

processor	: 1
BogoMIPS	: 243.75
Features	: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm lrcpc dcpop asimddp ssbs
CPU implementer	: 0x41
CPU architecture: 8
CPU variant	: 0x3
CPU part	: 0xd0c
CPU revision	: 1

[imwints]

Oopsie, I was sleeping... 😮‍💨 Yeah, it is unusual that the required fields are missing there. I guess this is due to containerization. We need to add a fallback if the cpuinfo isn't complete

[daniejstriata]

I logged an issue with AWS team here: https://github.com/amazonlinux/amazon-linux-2023/issues/455 Let's see if they can improve the output.

[NewZEROByxhapi]

ช่วยแก้บัคด้วย