bpytop icon indicating copy to clipboard operation
bpytop copied to clipboard

[REQUEST] Icon and .desktop file to launch bpytop from Gnome or other desktops

Open rsramkis opened this issue 4 years ago • 8 comments

I'd like to suggest that there is an icon and .desktop file created with the package so end uses can launch bpytop from the desktop. Presently HTOP does something similar.

I created the attached instructions and files to support this in Gnome. The Icon needs some work.

Thank you for the awesome tool.

BPYTOP.desktop [Desktop Entry] Version=1.0 Type=Application Comment=Show System Processes Name=BPYTOP Icon=/usr/share/pixmaps/BPYTOPlogo.png Exec=bpytop Categories=ConsoleOnly;System; GenericName=Process Viewer Terminal=true StartupNotify=true

BPYTOPlogo Install BPYTOP.txt

rsramkis avatar Aug 05 '20 02:08 rsramkis

I think I would leave this up to distribution packagers instead, but I could maybe add this as a template for future packages.

aristocratos avatar Aug 11 '20 18:08 aristocratos

I only thought about creating something standard (e.g. icon and .desktop files) just because I saw something similar in the HTOP Github source code [(https://github.com/hishamhm/htop)]. Its not always clear what the standard should be. But I'm all for making it more accessible to people (its a great implementation).

rsramkis avatar Aug 11 '20 19:08 rsramkis

One remark, if you ever do this, don't hard-code the icon. This is necessary so icon themes can make an icon for it.

Replace the icon line by: Icon=com.github.aristocratos.BpyTOP

gregorydk avatar Oct 17 '20 10:10 gregorydk

I think that a terminal application installing a desktop file is a no-no. Perhaps add an AUR package, something like bpytop-desktop for users that want this?

CodeLongAndProsper90 avatar Nov 17 '20 15:11 CodeLongAndProsper90

End of the day what ever is done should allow users to more easily use the tool. A desktop icon raises the visibility of the application. I would caution on applying ones personal preference over giving end users reasonable options.

rsramkis avatar Nov 18 '20 02:11 rsramkis

Just my 2 cents as a package maintainer, I see how having a generic .desktop file would help, but I agree with aristocratos that it is better left up to the distro package maintainer.

I say this even though MX Linux ships the one I created during packaging for our users, but this is actually a personal preference for applications like these. It isn't that hard to do from scratch if it is not included. This allows the maintainers to do it properly to the standard for their distro.

SwampRabbit avatar Jan 10 '21 18:01 SwampRabbit

@CodeLongAndProsper90: While adding a desktop file and icon is a technically an "extra feature", it's rather flimsy. Also, bpytop-desktop makes it sound like like a GUI.

See AUR submission guidelines:

The submitted PKGBUILDs must not build applications already in any of the official binary repositories under any circumstances... Exception to this strict rule may only be packages having extra features enabled and/or patches in comparison to the official ones.

I would ask the Arch community package maintainer if he'd be willing to add them to the existing package.

yochananmarqos avatar Jan 10 '21 21:01 yochananmarqos