http-types icon indicating copy to clipboard operation
http-types copied to clipboard

Either a bug or an error in documentation for encodePathSegments

Open lagunoff opened this issue 3 years ago • 1 comments

Here https://github.com/aristidb/http-types/blob/master/Network/HTTP/Types/URI.hs#L253 documentation states Performs percent encoding on all unreserved characters, as well as @\:\@\=\+\$@, while under the hood it calls urlEncodeBuilder False which does not escape characters :@&=+$,. Also in the docs the characters :@&=+$, called unreserved but they are actually reserved https://developers.google.com/maps/url-encoding. I also send related PR here https://github.com/fizruk/http-api-data/pull/119

lagunoff avatar Jul 19 '22 14:07 lagunoff

Fixed in 0.12.4 [Vlix#1]

Vlix avatar Nov 30 '23 19:11 Vlix