avd icon indicating copy to clipboard operation
avd copied to clipboard

Refactor(pyavd): Improve typing for python-avd/pyavd/_schema/

Open Vibhu-gslab opened this issue 5 months ago • 4 comments

Change Summary

Fixing pyright errors for python-avd/pyavd/_schema/

Related Issue(s)

Fixes Part of https://github.com/aristanetworks/avd-internal/issues/186 Fixes Part of https://github.com/aristanetworks/avd-internal/issues/321

Component(s) name

pyavd.api

Proposed changes

Fixing pyright errors

How to test

Run pre-commit run pyright --all

Checklist

Repository Checklist

  • [x] My code has been rebased from devel before I start
  • [x] I have read the CONTRIBUTING document.
  • [ ] My change requires a change to the documentation and documentation have been updated accordingly.
  • [x] I have updated molecule CI testing accordingly. (check the box if not applicable)

Vibhu-gslab avatar Nov 13 '25 07:11 Vibhu-gslab

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6152
# Activate the virtual environment
source test-avd-pr-6152/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@pyright_schema#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,pyright_schema --force
# Optional: Install AVD examples
cd test-avd-pr-6152
ansible-playbook arista.avd.install_examples

github-actions[bot] avatar Nov 13 '25 07:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Nov 14 '25 16:11 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Nov 17 '25 10:11 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 12 '25 16:12 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Dec 12 '25 16:12 github-actions[bot]