avd icon indicating copy to clipboard operation
avd copied to clipboard

Feat(eos_cli_config_gen): add sFlow sample output subinterface support

Open philippebureau opened this issue 1 year ago • 4 comments

Change Summary

add sflow sample output subinterface to eos_cli_config_gen

Related Issue(s)

N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

sflow: sample_output_subinterface:

How to test

check molecule test update

Checklist

Repository Checklist

  • [x] My code has been rebased from devel before I start
  • [x] I have read the CONTRIBUTING document.
  • [x] My change requires a change to the documentation and documentation have been updated accordingly.
  • [x] I have updated molecule CI testing accordingly. (check the box if not applicable)

philippebureau avatar Dec 22 '23 17:12 philippebureau

I merged the input variant. Please resolve all the conflicts.

ClausHolbechArista avatar Jan 03 '24 08:01 ClausHolbechArista

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 03 '24 08:01 github-actions[bot]

@philippebureau moving this one to draft. It needs some attention to rebase, resolve conflicts and rerun pre-commit.

ClausHolbechArista avatar Jan 23 '24 08:01 ClausHolbechArista

Need to rebase and resolve conflicts in this PR. Otherwise LGTM, tested it on ATD lab.

Shivani-gslab avatar Feb 14 '24 10:02 Shivani-gslab

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Mar 04 '24 07:03 github-actions[bot]