avd icon indicating copy to clipboard operation
avd copied to clipboard

Fix(eos_design): eos_designs_shared_utils module routing.py does not render bgp vrf configuration if vtep is disabled for the node_type

Open philippebureau opened this issue 1 year ago • 6 comments

Issue Summary

When configuring VRF BGP configuration in tenants, configuration is not rendred if the vtep key is set to false for the node_type.

The issue seems to be here: https://github.com/aristanetworks/ansible-avd/blob/devel/ansible_collections/arista/avd/roles/eos_designs/python_modules/network_services/router_bgp.py#L125

The module checks if the device in an overlay device and if not, bypass the render of router bgp vrf config

If I disable the overlay check in the module, the rendered output has evpn relevant configuration because the module set evpn as default (see line 135 in the module)

   vrf INTERCONNECT_VRF
      rd 10.112.10.2:15
      route-target import evpn 15:15
      route-target export evpn 15:15
      router-id 10.112.10.2
      neighbor 172.23.0.24 remote-as 65101
      neighbor 172.23.0.24 description ISP FW Peer2
      redistribute connected
      !
      address-family ipv4
         neighbor 172.23.0.24 activate

if I change the "address_families" to vpn-ipv4 under the vrf, no bgp vrf configuration is rendered

Which component(s) of AVD impacted

eos_desings Network services VRF BGP configuration

How do you run AVD ?

AVD 4.1.0, ansible-core 2.14.6

Steps to reproduce

Create a node_type that disable vtep:

  - key: interconnect_leaf
    type: interconnect-leaf
    connected_endpoints: true
    mlag_support: true
    network_services:
      l2: true
      l3: true
    vtep: false

configure eos_designs network services VRF BGP configuration :

tenants:
  - name: INTERCONNECT
    vrfs:
      - name: INTERCONNECT_VRF
        description: INTERCONNECT
        
  # L3 BGP Configuration
        bgp_peers:
          - ip_address: 172.23.0.34
            remote_as: 65100
            nodes:
              - NY-TCC1-0102-EX-DMZ-SW01

no configuration is rendred under 'router bgp xxx' for the VRF



### Relevant log output

_No response_

### Contributing Guide

- [X] I agree to follow this project's Code of Conduct

philippebureau avatar Jul 20 '23 18:07 philippebureau